Attention is currently required from: fixeria.

Patch set 2:Code-Review +1

View Change

1 comment:

• File src/gsm/gsm44021.c:

  • Patch Set #2, Line 30:

    if 0
    	[GSM48_CMODE_DATA_14k5] = {
    		/* TCH/F14.4: 290 bits every 20 ms (14.5 kbit/s) */
    		.fr = { .num_frames = 1, .num_bits = 290 },
    	},
    #endif
    

    i'm not quite sure I like that kind of commented-out data structure in libosmocore. After all, this data structure is describing bits from the specification, and whether or not other parts of libosmocore may or may not implement TCH/F14.4, the definitions stated here are still true, right?

To view, visit change 35914. To unsubscribe, or for help writing mail filters, visit settings.