Attention is currently required from: laforge, pespin, dexter.
jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/33548 )
Change subject: ASCI: Support conference briding with 1..n connections ......................................................................
Patch Set 3:
(8 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmo-mgw/+/33548/comment/1d760bac_784ed256 PS2, Line 12: than 2 connections.
please rephrase this, I don't understand: […]
Due to reworking the commit message changed.
https://gerrit.osmocom.org/c/osmo-mgw/+/33548/comment/675aa63f_c157604f PS2, Line 15: set to (one of) the other connection that shall send out RTP.
connection(s)
Due to reworking the commit message changed.
https://gerrit.osmocom.org/c/osmo-mgw/+/33548/comment/7d982948_9ab5963a PS2, Line 16: All connection that send RTP have "send_next" pointer set to the next
connections
Due to reworking the commit message changed.
Patchset:
PS2:
mh. […]
The patch uses a loop now. It is a fundamental change, so worth looking at the whole patch again.
File src/libosmo-mgcp/mgcp_protocol.c:
https://gerrit.osmocom.org/c/osmo-mgw/+/33548/comment/116aa25d_ce72ab4f PS2, Line 970: if (llist_count(&endp->conns) >= endp->type->max_conns) {
It is not immediately obvious for me where you now check endp->type->max_conns. […]
In the current version of the patch the max_conns are not set (remain 0) for RTP bridge endpoints. The checks will be performed only if max_conns != 0.
File src/libosmo-mgcp/mgcp_trunk.c:
https://gerrit.osmocom.org/c/osmo-mgw/+/33548/comment/439ae64a_6a7ee7f8 PS2, Line 311: /* Interconnect payload of connections depending on their mode.
"Interconnect payload of connections" I wonder what this means. […]
Due to reworking this change is not required anymore.
https://gerrit.osmocom.org/c/osmo-mgw/+/33548/comment/143f945e_7596cefa PS2, Line 352: *
For public functions we usually use doxygen syntax. […]
Due to reworking this change is not required anymore.
https://gerrit.osmocom.org/c/osmo-mgw/+/33548/comment/7bde8063_1acd94e6 PS2, Line 353: */
maybe the function should be called mgcp_trunk_connect_conn. […]
Due to reworking this change is not required anymore.
-
jolly