Attention is currently required from: laforge, pespin, dexter.
8 comments:
Commit Message:
Patch Set #2, Line 12: than 2 connections.
please rephrase this, I don't understand: […]
Due to reworking the commit message changed.
Patch Set #2, Line 15: set to (one of) the other connection that shall send out RTP.
connection(s)
Due to reworking the commit message changed.
Patch Set #2, Line 16: All connection that send RTP have "send_next" pointer set to the next
connections
Due to reworking the commit message changed.
Patchset:
mh. […]
The patch uses a loop now. It is a fundamental change, so worth looking at the whole patch again.
File src/libosmo-mgcp/mgcp_protocol.c:
Patch Set #2, Line 970: if (llist_count(&endp->conns) >= endp->type->max_conns) {
It is not immediately obvious for me where you now check endp->type->max_conns. […]
In the current version of the patch the max_conns are not set (remain 0) for RTP bridge endpoints. The checks will be performed only if max_conns != 0.
File src/libosmo-mgcp/mgcp_trunk.c:
Patch Set #2, Line 311: /* Interconnect payload of connections depending on their mode.
"Interconnect payload of connections" I wonder what this means. […]
Due to reworking this change is not required anymore.
For public functions we usually use doxygen syntax. […]
Due to reworking this change is not required anymore.
maybe the function should be called mgcp_trunk_connect_conn. […]
Due to reworking this change is not required anymore.
To view, visit change 33548. To unsubscribe, or for help writing mail filters, visit settings.