Attention is currently required from: fixeria.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/36342?usp=email )
Change subject: e1line_dump_vty(): dump keepalive state and params ......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1: very nice!
File src/e1_input_vty.c:
https://gerrit.osmocom.org/c/libosmo-abis/+/36342/comment/4f307a3b_57c0460a PS1, Line 460: static void e1line_ka_dump_vty(struct vty *vty, const struct e1inp_line *line) I would suggest making clear that this is TCP keepalive: * name the function e1line_tcp_ka_dump_vty * Print "TCP Keepalive" instead of "Keepalive"