Attention is currently required from: fixeria.
View Change
2 comments:
Patchset:
File src/e1_input_vty.c:
Patch Set #1, Line 460: static void e1line_ka_dump_vty(struct vty *vty, const struct e1inp_line *line)
I would suggest making clear that this is TCP keepalive:
- name the function e1line_tcp_ka_dump_vty
- Print "TCP Keepalive" instead of "Keepalive"
To view, visit change 36342. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I17bd991850333ee794ab216f474b5e045fb01fa3
Gerrit-Change-Number: 36342
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith@sysmocom.de>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Comment-Date: Tue, 19 Mar 2024 08:19:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment