Attention is currently required from: pespin. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/30210 )

Change subject: osmux: Introduce API osmux_xfrm_input_set_name() ......................................................................

Patch Set 2: Code-Review-1

(3 comments)

File src/osmux_input.c:

https://gerrit.osmocom.org/c/libosmo-netif/+/30210/comment/57b3dbcc_14124bb5 PS2, Line 732: link->name = talloc_asprintf(link, "%p", h); What's the point of printing pointer as name in here?

https://gerrit.osmocom.org/c/libosmo-netif/+/30210/comment/1bbc9bdf_46165304 PS2, Line 777: osmo_talloc_replace_string(link, &link->name, name); If it will be replaced with actual name in here? Why not simply set NULL instead of random placeholder?

File tests/testsuite.at:

https://gerrit.osmocom.org/c/libosmo-netif/+/30210/comment/3d848f1c_e28b97c4 PS2, Line 14: # Following sed gets rid of pointer addresses to have reproducible output: This looks like complex, hard to read and maintain solution for the problem introduced in the very same patch.