Attention is currently required from: pespin.

Patch set 2:Code-Review -1

View Change

3 comments:

• File src/osmux_input.c:

  • Patch Set #2, Line 732: link->name = talloc_asprintf(link, "%p", h);

    What's the point of printing pointer as name in here?

  • Patch Set #2, Line 777: osmo_talloc_replace_string(link, &link->name, name);

    If it will be replaced with actual name in here?
    Why not simply set NULL instead of random placeholder?

• File tests/testsuite.at:

  • Patch Set #2, Line 14: # Following sed gets rid of pointer addresses to have reproducible output:

    This looks like complex, hard to read and maintain solution for the problem introduced in the very same patch.

To view, visit change 30210. To unsubscribe, or for help writing mail filters, visit settings.