Attention is currently required from: daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33336 ) Change subject: stream: Allow setting name printed during logging ...................................................................... Patch Set 2: (3 comments) File src/stream.c: https://gerrit.osmocom.org/c/libosmo-netif/+/33336/comment/39ced512_314770c5 PS1, Line 317: LOGSCLI(cli, LOGL_INFO, "retrying reconnect in %d seconds...\n", It's actually related, because I change the printing in LOGSCLI to drop the function name, so now in here a bit more context is welcome. https://gerrit.osmocom.org/c/libosmo-netif/+/33336/comment/9ccac6ed_52e1aa72 PS1, Line 421: LOGSCLI(cli, LOGL_ERROR, "send: not connected, dropping data!\n"); Same as above, related. https://gerrit.osmocom.org/c/libosmo-netif/+/33336/comment/802f9462_c8ad4a44 PS1, Line 1228: struct osmo_stream_srv_link *osmo_stream_srv_link_create(void *ctx) Is it really needed? calling osmo_stream_srv_link_set_name() after is good enough. There's even no need to call set_name(), a user may not care about the naming. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33336 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I539a0d29d11348efe702f971965a55cf56db5c59 Gerrit-Change-Number: 33336 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 16 Jun 2023 12:33:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: comment