Attention is currently required from: daniel.

View Change

3 comments:

• File src/stream.c:

  • Patch Set #1, Line 317: LOGSCLI(cli, LOGL_INFO, "retrying reconnect in %d seconds...\n",

    Unrelated

    It's actually related, because I change the printing in LOGSCLI to drop the function name, so now in here a bit more context is welcome.

  • Patch Set #1, Line 421: LOGSCLI(cli, LOGL_ERROR, "send: not connected, dropping data!\n");

    Unrelated

    Same as above, related.

  • Patch Set #1, Line 1228: struct osmo_stream_srv_link *osmo_stream_srv_link_create(void *ctx)

    Also add a create2() function with name as parameter.

    Is it really needed? calling osmo_stream_srv_link_set_name() after is good enough. There's even no need to call set_name(), a user may not care about the naming.

To view, visit change 33336. To unsubscribe, or for help writing mail filters, visit settings.