Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30950 )

Change subject: layer23: Add VTY supports for l23_apps ......................................................................

Patch Set 1: Code-Review-1

(4 comments)

Patchset:

PS1: CR-1 for talloc_free().

File src/host/layer23/src/common/main.c:

https://gerrit.osmocom.org/c/osmocom-bb/+/30950/comment/88c7a6a0_a2d3cc45 PS1, Line 271: handle_options I may be missing something, but I believe option parsing, config parsing, and setting up the VTY should be done as early as possible. Otherwise, for instance, logging from l23_app_init() would not take the logging configuration into account.

https://gerrit.osmocom.org/c/osmocom-bb/+/30950/comment/97ba8e0c_8637cfd9 PS1, Line 274: OSMO_ASSERT(app->vty_info); cosmetic: setting up VTY stuff could be done in a separate [static] function, so that it's easier to read the main.

https://gerrit.osmocom.org/c/osmocom-bb/+/30950/comment/5072942e_a6eca72f PS1, Line 331: talloc_free(config_file This looks wrong to me. We did not allocate config_file using talloc, right?