Attention is currently required from: pespin.
Patch set 1:Code-Review -1
4 comments:
Patchset:
CR-1 for talloc_free().
File src/host/layer23/src/common/main.c:
Patch Set #1, Line 271: handle_options
I may be missing something, but I believe option parsing, config parsing, and setting up the VTY should be done as early as possible. Otherwise, for instance, logging from l23_app_init() would not take the logging configuration into account.
Patch Set #1, Line 274: OSMO_ASSERT(app->vty_info);
cosmetic: setting up VTY stuff could be done in a separate [static] function, so that it's easier to read the main.
Patch Set #1, Line 331: talloc_free(config_file
This looks wrong to me. We did not allocate config_file using talloc, right?
To view, visit change 30950. To unsubscribe, or for help writing mail filters, visit settings.