Attention is currently required from: pespin, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/29264 )

Change subject: trxcon: Initial support for forwarding AMR ......................................................................

Patch Set 8: Code-Review+1

(4 comments)

File src/host/trxcon/src/sched_lchan_tchf.c:

https://gerrit.osmocom.org/c/osmocom-bb/+/29264/comment/82eac0bf_e49c9b4f PS3, Line 47: sched_tchf_dl_amr_cmi_map

Cool! Would you submit a patch to osmo-bts. […]

I will do this myself.

https://gerrit.osmocom.org/c/osmocom-bb/+/29264/comment/b20f544c_cfba83ce PS3, Line 48: [11] = 1, /* TCH/F: a=4 / h=11 */

Please fix the alignment, I find the old variant a bit easier to read.

Done

https://gerrit.osmocom.org/c/osmocom-bb/+/29264/comment/8a18d5e7_2542084c PS3, Line 56: ul_amr_fn_is_cmi

So please if you really want it in some specific way, fix it first in osmo-bts and then I can do the […]

Ok, I will do this myself.

File src/target/firmware/layer1/l23_api.c:

https://gerrit.osmocom.org/c/osmocom-bb/+/29264/comment/97e07efd_c2a426b4 PS1, Line 729:

unrelated ws removal

Still not addressed, but not critical.