Attention is currently required from: pespin, dexter.

Patch set 8:Code-Review +1

View Change

4 comments:

• File src/host/trxcon/src/sched_lchan_tchf.c:

  • Patch Set #3, Line 47: sched_tchf_dl_amr_cmi_map

    Cool! Would you submit a patch to osmo-bts. […]

    I will do this myself.

  • Patch Set #3, Line 48: [11] = 1, /* TCH/F: a=4 / h=11 */

    Please fix the alignment, I find the old variant a bit easier to read.

    Done

  • Patch Set #3, Line 56: ul_amr_fn_is_cmi

    So please if you really want it in some specific way, fix it first in osmo-bts and then I can do the […]

    Ok, I will do this myself.

• File src/target/firmware/layer1/l23_api.c:

  • Patch Set #1, Line 729:

    unrelated ws removal

    Still not addressed, but not critical.

To view, visit change 29264. To unsubscribe, or for help writing mail filters, visit settings.