Attention is currently required from: neels, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662 )

Change subject: Add bsc_nat fsm ......................................................................

Patch Set 5:

(2 comments)

File include/osmocom/bsc_nat/bsc_nat_fsm.h:

https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662/comment/de08ecc5_d24162bf PS5, Line 22: void bsc_nat_fsm_start(struct bsc_nat *bsc_nat);

The API is a bit weird, because you return fi in bsc_nat_fsm_alloc, which is then assigned externall […]

Done

File src/osmo-bsc-nat/bsc_nat_fsm.c:

https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662/comment/6f82e076_cb4c7617 PS5, Line 136: static void st_stopped_on_enter(struct osmo_fsm_inst *fi, uint32_t prev_state)

Please put the on_enter function above the event one.

Done