Attention is currently required from: neels, pespin.
osmith has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662 )
Change subject: Add bsc_nat fsm
......................................................................
Patch Set 5:
(2 comments)
File include/osmocom/bsc_nat/bsc_nat_fsm.h:
https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662/comment/de08ecc5_d24162bf
PS5, Line 22: void bsc_nat_fsm_start(struct bsc_nat *bsc_nat);
The API is a bit weird, because you return fi in
bsc_nat_fsm_alloc, which is then assigned externall […]
Done
File src/osmo-bsc-nat/bsc_nat_fsm.c:
https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662/comment/6f82e076_cb4c7617
PS5, Line 136: static void st_stopped_on_enter(struct osmo_fsm_inst *fi, uint32_t
prev_state)
Please put the on_enter function above the event one.
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc-nat
Gerrit-Branch: master
Gerrit-Change-Id: I7d52fa649c397582b18a1a7dcc40bb407f3b2c97
Gerrit-Change-Number: 26662
Gerrit-PatchSet: 5
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 21 Jan 2022 16:36:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment