Attention is currently required from: neels, pespin.

View Change

2 comments:

• File include/osmocom/bsc_nat/bsc_nat_fsm.h:

  • Patch Set #5, Line 22: void bsc_nat_fsm_start(struct bsc_nat *bsc_nat);

    The API is a bit weird, because you return fi in bsc_nat_fsm_alloc, which is then assigned externall […]

    Done

• File src/osmo-bsc-nat/bsc_nat_fsm.c:

  • Patch Set #5, Line 136: static void st_stopped_on_enter(struct osmo_fsm_inst *fi, uint32_t prev_state)

    Please put the on_enter function above the event one.

    Done

To view, visit change 26662. To unsubscribe, or for help writing mail filters, visit settings.