Attention is currently required from: jolly, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31108 )

Change subject: layer23: Support configuring GSMTAP through VTY in l23 apps. ......................................................................

Patch Set 3:

(3 comments)

Commit Message:

https://gerrit.osmocom.org/c/osmocom-bb/+/31108/comment/e4590ff6_c3d752c9 PS2, Line 13: gsmtap

I'm not mixing them here, I'm establishing 2 layers of granularity. […]

Ok, let's see what the others think about the command style/consistency.

File src/host/layer23/include/osmocom/bb/common/l23_app.h:

https://gerrit.osmocom.org/c/osmocom-bb/+/31108/comment/b7db2693_38af60c8 PS3, Line 20: l23_gsmtap_category Maybe l23_gsmtap_gprs_category? Or have GPRS prefix in all enum entries?

File src/host/layer23/src/common/vty.c:

https://gerrit.osmocom.org/c/osmocom-bb/+/31108/comment/924827a2_3b38d154 PS3, Line 138: gsmtap_sapi_names There exists gsmtap_gsm_channel_names[] in libosmocore.git, maybe use it?