Attention is currently required from: jolly, pespin.

View Change

3 comments:

• Commit Message:

  • Patch Set #2, Line 13: gsmtap

    I'm not mixing them here, I'm establishing 2 layers of granularity. […]

    Ok, let's see what the others think about the command style/consistency.

• File src/host/layer23/include/osmocom/bb/common/l23_app.h:

  • Patch Set #3, Line 20: l23_gsmtap_category

    Maybe l23_gsmtap_gprs_category? Or have GPRS prefix in all enum entries?

• File src/host/layer23/src/common/vty.c:

  • Patch Set #3, Line 138: gsmtap_sapi_names

    There exists gsmtap_gsm_channel_names[] in libosmocore.git, maybe use it?

To view, visit change 31108. To unsubscribe, or for help writing mail filters, visit settings.