Attention is currently required from: pespin, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28602 ) Change subject: Add initial SBc-AP support to osmo-cbc ...................................................................... Patch Set 8: (13 comments) File debian/control: https://gerrit.osmocom.org/c/osmo-cbc/+/28602/comment/6396d6e2_f049c077 PS8, Line 18: libsctp-dev, contrib/osmo-cbc.spec.in also needs to be adjusted, this should do it: BuildRequires: pkgconfig(libsctp) https://pkgs.org/search/?q=pkgconfig(libsctp) File include/osmocom/cbc/sbcap_server.h: https://gerrit.osmocom.org/c/osmo-cbc/+/28602/comment/cb100f1c_0ef14f55 PS8, Line 3: //#include <osmocom/gsm/sbcap.h> commented out include? File src/cbc_main.c: https://gerrit.osmocom.org/c/osmo-cbc/+/28602/comment/5670444b_a65bca57 PS8, Line 284: binidng binding File src/sbcap_msg.c: https://gerrit.osmocom.org/c/osmo-cbc/+/28602/comment/f178fe01_9ecb4360 PS8, Line 3: /* (C) 2019 by Harald Welte &lt;laforge(a)gnumonks.org&gt; (copyright 2022, also in other files?) https://gerrit.osmocom.org/c/osmo-cbc/+/28602/comment/416dd11d_d8ae0741 PS8, Line 40: #if 0 There are multiple "if 0" style commented out code blocks below. Why add them? File src/sbcap_server.c: https://gerrit.osmocom.org/c/osmo-cbc/+/28602/comment/6e906d34_d5fa4fa0 PS8, Line 62: 1500 should be a valid talloc context instead. Either pass it as argument or maybe make a global variable here as talloc context? https://gerrit.osmocom.org/c/osmo-cbc/+/28602/comment/49c6e913_316e0d14 PS8, Line 184: /* FIXME */ unresolved fixme, should it return here? File src/sbcap_server_fsm.c: https://gerrit.osmocom.org/c/osmo-cbc/+/28602/comment/94ec5697_59587ba6 PS8, Line 71: //SBcAP_SBC_AP_PDU_t *pdu; not needed? https://gerrit.osmocom.org/c/osmo-cbc/+/28602/comment/7a498afe_87411b42 PS8, Line 78: //pdu = data; not needed? https://gerrit.osmocom.org/c/osmo-cbc/+/28602/comment/da97eedd_1e748582 PS8, Line 148: /* static const long asn_VAL_1_SBcAP_id_Message_Identifier = 5; */ remove? https://gerrit.osmocom.org/c/osmo-cbc/+/28602/comment/c9189b2e_49e356ac PS8, Line 228: xpected expected https://gerrit.osmocom.org/c/osmo-cbc/+/28602/comment/1b56255c_768b2167 PS8, Line 303: //else commented out code, remove? File src/smscb_peer_fsm.c: https://gerrit.osmocom.org/c/osmo-cbc/+/28602/comment/63078e94_c8998b40 PS8, Line 311: //SBcAP_SBC_AP_PDU_t *pdu = NULL; remove? also "//pdu = data" twice below, also in smscb_p_fsm_wait_delete_ack -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28602 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: Ib278bc1d1a74459814016fef7a8fe21cc29d46c9 Gerrit-Change-Number: 28602 Gerrit-PatchSet: 8 Gerrit-Owner: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Reviewer: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-Reviewer: osmith &lt;osmith(a)sysmocom.de&gt; Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Attention: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Attention: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Comment-Date: Mon, 18 Jul 2022 09:12:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment