Attention is currently required from: pespin, fixeria.
13 comments:
File debian/control:
Patch Set #8, Line 18: libsctp-dev,
contrib/osmo-cbc.spec.in also needs to be adjusted, this should do it:
BuildRequires: pkgconfig(libsctp)
https://pkgs.org/search/?q=pkgconfig(libsctp)
File include/osmocom/cbc/sbcap_server.h:
Patch Set #8, Line 3: //#include <osmocom/gsm/sbcap.h>
commented out include?
File src/cbc_main.c:
Patch Set #8, Line 284: binidng
binding
File src/sbcap_msg.c:
Patch Set #8, Line 3: /* (C) 2019 by Harald Welte <laforge@gnumonks.org>
(copyright 2022, also in other files?)
Patch Set #8, Line 40: #if 0
There are multiple "if 0" style commented out code blocks below. Why add them?
File src/sbcap_server.c:
should be a valid talloc context instead. Either pass it as argument or maybe make a global variable here as talloc context?
Patch Set #8, Line 184: /* FIXME */
unresolved fixme, should it return here?
File src/sbcap_server_fsm.c:
Patch Set #8, Line 71: //SBcAP_SBC_AP_PDU_t *pdu;
not needed?
Patch Set #8, Line 78: //pdu = data;
not needed?
Patch Set #8, Line 148: /* static const long asn_VAL_1_SBcAP_id_Message_Identifier = 5; */
remove?
Patch Set #8, Line 228: xpected
expected
Patch Set #8, Line 303: //else
commented out code, remove?
File src/smscb_peer_fsm.c:
Patch Set #8, Line 311: //SBcAP_SBC_AP_PDU_t *pdu = NULL;
remove? also "//pdu = data" twice below, also in smscb_p_fsm_wait_delete_ack
To view, visit change 28602. To unsubscribe, or for help writing mail filters, visit settings.