Attention is currently required from: jolly, dexter.

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/33546 )

Change subject: ASCI: Add new mode for voice group/broadcast call ......................................................................

Patch Set 1:

(3 comments)

Commit Message:

https://gerrit.osmocom.org/c/osmo-mgw/+/33546/comment/b800c87c_e9fe240d PS1, Line 19: Because there is no transcoding within the endpoint, only one connection I'm not getting this paragraph. IIUC all connections should be receiving the RTP in "confecho" as explained above?

File src/libosmo-mgcp/mgcp_protocol.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/33546/comment/c95b6d6d_a3a58e32 PS1, Line 1091: && (conn->conn->mode & MGCP_CONN_SEND_ONLY) I'm not a big fan of reusing the flags for the SEND_ONLY for CONFECHO mode here, it makes stuff difficult to follow and prone to error imho.

File tests/mgcp/mgcp_test.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/33546/comment/1e7744da_16c3e501 PS1, Line 715: /* Check that LOOPBACK disables all output */ I have the feeling you are presenting 2 patches in one here. All the loopback stuff probably has to be provided as a previous separated patch.