Attention is currently required from: jolly, dexter.

View Change

3 comments:

• Commit Message:

  • Patch Set #1, Line 19: Because there is no transcoding within the endpoint, only one connection

    I'm not getting this paragraph. IIUC all connections should be receiving the RTP in "confecho" as explained above?

• File src/libosmo-mgcp/mgcp_protocol.c:

  • Patch Set #1, Line 1091: && (conn->conn->mode & MGCP_CONN_SEND_ONLY)

    I'm not a big fan of reusing the flags for the SEND_ONLY for CONFECHO mode here, it makes stuff difficult to follow and prone to error imho.

• File tests/mgcp/mgcp_test.c:

  • Patch Set #1, Line 715: /* Check that LOOPBACK disables all output */

    I have the feeling you are presenting 2 patches in one here. All the loopback stuff probably has to be provided as a previous separated patch.

To view, visit change 33546. To unsubscribe, or for help writing mail filters, visit settings.