Attention is currently required from: osmith, pespin, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27758 ) Change subject: osmo-bts-trx: use C/I in the AMR link adaptation loop ...................................................................... Patch Set 5: (2 comments) File src/osmo-bts-trx/amr_loop.c: https://gerrit.osmocom.org/c/osmo-bts/+/27758/comment/4af9315a_34669b28 PS5, Line 76: const int thresh_lower_cb = cfg->mode[chan_state->dl_cmr - 1].threshold * 5; No, as per the specs hysteresis is only used to calculate the upper threshold. See 3GPP TS 45.009, section 3.4.2, figure 2. https://gerrit.osmocom.org/c/osmo-bts/+/27758/comment/1705888e_d7989cbc PS5, Line 86: } else if (chan_state->dl_cmr < chan_state->codecs - 1) { Yes, 'else if' is wrong. Fixed in I4c0fb28813373c3d4addd28c66f5136d2c4f9ed8. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27758 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ide84bf864f56020c0265cfb9731615d4f7bad7f5 Gerrit-Change-Number: 27758 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter &lt;pmaier(a)sysmocom.de&gt; Gerrit-Reviewer: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-Reviewer: osmith &lt;osmith(a)sysmocom.de&gt; Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Attention: osmith &lt;osmith(a)sysmocom.de&gt; Gerrit-Attention: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Attention: dexter &lt;pmaier(a)sysmocom.de&gt; Gerrit-Comment-Date: Wed, 20 Apr 2022 11:18:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith &lt;osmith(a)sysmocom.de&gt; Gerrit-MessageType: comment