Attention is currently required from: osmith, pespin, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27758 )

Change subject: osmo-bts-trx: use C/I in the AMR link adaptation loop ......................................................................

Patch Set 5:

(2 comments)

File src/osmo-bts-trx/amr_loop.c:

https://gerrit.osmocom.org/c/osmo-bts/+/27758/comment/4af9315a_34669b28 PS5, Line 76: const int thresh_lower_cb = cfg->mode[chan_state->dl_cmr - 1].threshold * 5;

is the hysteresis missing here (see thresh_upper_cb)?

No, as per the specs hysteresis is only used to calculate the upper threshold. See 3GPP TS 45.009, section 3.4.2, figure 2.

https://gerrit.osmocom.org/c/osmo-bts/+/27758/comment/1705888e_d7989cbc PS5, Line 86: } else if (chan_state->dl_cmr < chan_state->codecs - 1) {

just to be sure, is the "else if" here intentional, instead of just "if"? given that dl_cmr is an ui […]

Yes, 'else if' is wrong. Fixed in I4c0fb28813373c3d4addd28c66f5136d2c4f9ed8.