Attention is currently required from: osmith, pespin, dexter.

View Change

2 comments:

• File src/osmo-bts-trx/amr_loop.c:

  • Patch Set #5, Line 76: const int thresh_lower_cb = cfg->mode[chan_state->dl_cmr - 1].threshold * 5;

    is the hysteresis missing here (see thresh_upper_cb)?

    No, as per the specs hysteresis is only used to calculate the upper threshold. See 3GPP TS 45.009, section 3.4.2, figure 2.

  • Patch Set #5, Line 86: } else if (chan_state->dl_cmr < chan_state->codecs - 1) {

    just to be sure, is the "else if" here intentional, instead of just "if"? given that dl_cmr is an ui […]

    Yes, 'else if' is wrong. Fixed in I4c0fb28813373c3d4addd28c66f5136d2c4f9ed8.

To view, visit change 27758. To unsubscribe, or for help writing mail filters, visit settings.