Attention is currently required from: Hoernchen, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30416 ) Change subject: ms-trx support ...................................................................... Patch Set 15: Code-Review-1 (1 comment) Patchset: PS15: Looks like you forgot to update contrib/jenkins.sh, so your code is not being compiled during the build verification. I tried to build it on my machine and got this error: CXX ms/osmo_trx_ms_uhd-logging.o ms/logging.cpp:73:1: sorry, unimplemented: non-trivial designated initializers not supported 73 | }; | ^ I am also seeing warnings like this: In file included from ms/ms_upper.cpp:23: ms/ms.h:201:65: warning: ‘optnone’ attribute directive ignored [-Wattributes] 201 | void grab_bursts(dev_buf_t *rcd) __attribute__((optnone)); | ^ In file included from ms/ms_upper.cpp:51: ms/ms_upper.h:39:101: warning: ‘optnone’ attribute directive ignored [-Wattributes] 39 | bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone)); | -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30416 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I36c65a8c725c4da76dc70006cd96b0a2b6878e84 Gerrit-Change-Number: 30416 Gerrit-PatchSet: 15 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 11 Dec 2022 11:42:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment