Attention is currently required from: Hoernchen, pespin.

Patch set 15:Code-Review -1

View Change

1 comment:

• Patchset:

  • Patch Set #15:

    Looks like you forgot to update contrib/jenkins.sh, so your code is not being compiled during the build verification. I tried to build it on my machine and got this error:

      CXX      ms/osmo_trx_ms_uhd-logging.o
    ms/logging.cpp:73:1: sorry, unimplemented: non-trivial designated initializers not supported
       73 | };
          | ^

    I am also seeing warnings like this:

    In file included from ms/ms_upper.cpp:23:
    ms/ms.h:201:65: warning: ‘optnone’ attribute directive ignored [-Wattributes]
      201 |         void grab_bursts(dev_buf_t *rcd) __attribute__((optnone));
          |                                                                 ^
    In file included from ms/ms_upper.cpp:51:
    ms/ms_upper.h:39:101: warning: ‘optnone’ attribute directive ignored [-Wattributes]
       39 |         bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone));
          |

To view, visit change 30416. To unsubscribe, or for help writing mail filters, visit settings.