Attention is currently required from: fixeria, pespin.
lynxis lazus has posted comments on this change by lynxis lazus. (
https://gerrit.osmocom.org/c/osmo-sgsn/+/40699?usp=email )
Change subject: ranap: split mmctx related iu events into own function
......................................................................
Patch Set 1:
(2 comments)
File src/sgsn/gprs_ranap.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/40699/comment/dcfadb5e_c8af5268?us… :
PS1, Line 145: if (!ctx) {
why aren't you doing this check in the function
below? […]
because the new event NEW_AREA doesn't have a ctx
https://gerrit.osmocom.org/c/osmo-sgsn/+/40699/comment/8ea09343_0529ca74?us… :
PS1, Line 205: new_area
unused
ack. will be used in a following commit.
will remove it here.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-sgsn/+/40699?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Ie6f131d29da299f09e897240ec5c39a395ce6f1b
Gerrit-Change-Number: 40699
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 17 Jul 2025 09:38:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>