Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40717?usp=email ) Change subject: s1ap_proxy: fix per-eNB ?S1GW_CTR_S1AP_PROXY_IN_PKT_ALL ...................................................................... Patch Set 1: Code-Review+1 (2 comments) File src/s1ap_proxy.erl: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40717/comment/d3195cf6_9dff0... : PS1, Line 646: %% this is needed to count S1 Setup Req correctly This looks like yet another problem of not doing the handling/proxying of packets in 2 steps, ie. 1st step filling in some map/struct and then 2nd step acting on it (like incrementing the counter, patching and forwarding). https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40717/comment/44ddc13a_77875... : PS1, Line 649: _ -> this "_" should actually be "undefined" afaiu? -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40717?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: If57f0c43f41d5f38759f9746a4f6299d3233a450 Gerrit-Change-Number: 40717 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Thu, 17 Jul 2025 09:29:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes