Attention is currently required from: Hoernchen.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/32943 )
Change subject: ms: prettify scheduling + add odroid ......................................................................
Patch Set 1:
(3 comments)
Patchset:
PS1: Why not simply provide specific config files for specific platforms and keep the code generic?
File Transceiver52M/ms/ms.h:
https://gerrit.osmocom.org/c/osmo-trx/+/32943/comment/b4ed64ec_d0d593d9 PS1, Line 205: enum target { ODROID = 0, PI4 }; Do we really only want to be able to run this in ODROID or PI4? I don't see the point in having this kind of platform hardcoded here.
https://gerrit.osmocom.org/c/osmo-trx/+/32943/comment/6922eb21_a747f2b6 PS1, Line 291: hw_target(hw_cpus > 4 ? sched_params::target::ODROID : sched_params::target::PI4) so any platform with more than 4 cpus is considered "ODROID"? why not simply "GENERIC" or "GENERAL" then?