Attention is currently required from: Hoernchen.

View Change

3 comments:

• Patchset:

  • Patch Set #1:

    Why not simply provide specific config files for specific platforms and keep the code generic?

• File Transceiver52M/ms/ms.h:

  • Patch Set #1, Line 205: enum target { ODROID = 0, PI4 };

    Do we really only want to be able to run this in ODROID or PI4? I don't see the point in having this kind of platform hardcoded here.

  • Patch Set #1, Line 291: hw_target(hw_cpus > 4 ? sched_params::target::ODROID : sched_params::target::PI4)

    so any platform with more than 4 cpus is considered "ODROID"? why not simply "GENERIC" or "GENERAL" then?

To view, visit change 32943. To unsubscribe, or for help writing mail filters, visit settings.