Attention is currently required from: dexter, laforge.

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36324?usp=email )

Change subject: msgb: Also copy msgb {dst, lchan, cb} during msgb_copy_* ......................................................................

Patch Set 2: Code-Review+1

(1 comment)

File src/core/msgb.c:

https://gerrit.osmocom.org/c/libosmocore/+/36324/comment/7bd7ce73_efa9a6dd PS1, Line 320: * and adjusts the pointers (incl l1h-l4h) accordingly. The cb part is not copied.

I did a rather exhaustive study and could not find any osmocoom code that would rely on the existing […]

I think the cb was not copied as a performance reason, since lots of code doesn't use cb at all.

I personally think it's fine keeping the old behavior. You may want to add a copy_full() API which also copies the cb and other stuff.