Attention is currently required from: dexter, laforge.

Patch set 2:Code-Review +1

View Change

1 comment:

• File src/core/msgb.c:

  • Patch Set #1, Line 320: * and adjusts the pointers (incl l1h-l4h) accordingly. The cb part is not copied.

    I did a rather exhaustive study and could not find any osmocoom code that would rely on the existing […]

    I think the cb was not copied as a performance reason, since lots of code doesn't use cb at all.

    I personally think it's fine keeping the old behavior. You may want to add a copy_full() API which also copies the cb and other stuff.

To view, visit change 36324. To unsubscribe, or for help writing mail filters, visit settings.