Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/32273 ) Change subject: add static SS7 routing example to cs7-config.adoc ...................................................................... Patch Set 1: (7 comments) File common/chapters/cs7-config.adoc: https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/32273/comment/c6a5bdf0_55cf… PS1, Line 349: Osmocom SS7 supports dynamic routing, allowing minimal SS7 configuration. If all of your components support dynamic dynamic routing through Routing Key Management (RKM) https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/32273/comment/b9ea7ea6_27da… PS1, Line 373: - its own point-code -- has to match the PC in osmo-stp.cfg Perhaps better: "has to match its own PC entry in osmo-stp.cfg" https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/32273/comment/bd497920_c629… PS1, Line 376: - local+remote IP:port for M3UA -- have to match the IP:ports in osmo-stp.cfg IP:ports -> IP:port? https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/32273/comment/76341404_4c4e… PS1, Line 382: - local+remote IP:port for M3UA -- have to match the IP:ports in osmo-stp.cfg IP:ports -> IP:port? https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/32273/comment/cf66f13f_b500… PS1, Line 387: - all point-codes -- they have to match the PC in osmo-bsc.cfg and osmo-msc.cfg You list first point codes and afterwards routing keys in the MSC and BSC section. Makes sense to have same order here too. https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/32273/comment/66a938e1_d3b9… PS1, Line 388: - local+remote IP:port for M3UA -- have to match the IP:ports in osmo-bsc.cfg and osmo-msc.cfg IP:ports -> IP:port? https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/32273/comment/bfbc135b_6361… PS1, Line 390: .osmo-bsc.cfg I think it makes more sense to move each of these below the bullet list of each component above. This way you can check each bullet with the config file by the side. -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/32273 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I44afddf7004f5bf37eec706ca3da12c04f83f8fa Gerrit-Change-Number: 32273 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 12 Apr 2023 10:12:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment