Attention is currently required from: daniel, fixeria, laforge, neels.

dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42441?usp=email )

Change subject: transport: change APDU format paradigm ......................................................................

Patch Set 2:

(2 comments)

Patchset:

PS1:

don't you think it would make sense to have the strict APDU enabled by default? […]

For the apdu command in pySim-shell.py I think we should keep the non strict mode as default for some longer time. Printing a warning along with some info makes sense. I have added a warning along with some info now.

While thinking over the changes in the pySim.transport API I noticed that the apdu_strict mode is more of a workaround that we probably want to get rid off some day. I think the ultimate goal should be that we consistently use APDUs as specified in ISO/IEC 7816-3 everywhere.

So I reverted to the old Class-Property-Way but set the apdu_strict property to True by default. In the apdu command the mode is then switched depending on the status of the apdu_strict setable. The effect is the same but in the current form it will be easier to remove the workaround at some later point.

File pySim/commands.py:

https://gerrit.osmocom.org/c/pysim/+/42441/comment/6a0a4e8e_53a8fbe5?usp=ema... : PS1, Line 93: Args:

You're missing to update API docs here and below (new parameter).

Done