Attention is currently required from: daniel, fixeria, laforge, neels.
2 comments:
Patchset:
don't you think it would make sense to have the strict APDU enabled by default? […]
For the apdu command in pySim-shell.py I think we should keep the non strict mode as default for some longer time. Printing a warning along with some info makes sense. I have added a warning along with some info now.
While thinking over the changes in the pySim.transport API I noticed that the apdu_strict mode is more of a workaround that we probably want to get rid off some day. I think the ultimate goal should be that we consistently use APDUs as specified in ISO/IEC 7816-3 everywhere.
So I reverted to the old Class-Property-Way but set the apdu_strict property to True by default. In the apdu command the mode is then switched depending on the status of the apdu_strict setable. The effect is the same but in the current form it will be easier to remove the workaround at some later point.
File pySim/commands.py:
Patch Set #1, Line 93: Args:
You're missing to update API docs here and below (new parameter).
Done
To view, visit change 42441. To unsubscribe, or for help writing mail filters, visit settings.