Attention is currently required from: keith, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/34150 ) Change subject: vty: include local port when dumping RTP conns ...................................................................... Patch Set 1: Code-Review-1 (1 comment) File src/libosmo-mgcp/mgcp_conn.c: https://gerrit.osmocom.org/c/osmo-mgw/+/34150/comment/923d1c04_8bf53803 PS1, Line 373: "rtp:%u<->%u rtcp:%u)", I think you probably want to clearly print remote and local IP+port together so it becomes way clearer. See for instance osmo_sockaddr_to_str() and osmo_sockaddr_to_str_buf(). Maybe something like: snprintf(str, sizeof(str), "(%s/rtp, id:0x%s, local:%s (rtcp:%u), remote:%s (rtcp:%u))", ...); What does conn->name actually contain here btw? -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/34150 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ib89a6779e1d68c6600f00699d4303f6c0ee07132 Gerrit-Change-Number: 34150 Gerrit-PatchSet: 1 Gerrit-Owner: keith &lt;keith(a)rhizomatica.org&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter &lt;pmaier(a)sysmocom.de&gt; Gerrit-Reviewer: osmith &lt;osmith(a)sysmocom.de&gt; Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Attention: keith &lt;keith(a)rhizomatica.org&gt; Gerrit-Attention: dexter &lt;pmaier(a)sysmocom.de&gt; Gerrit-Comment-Date: Mon, 21 Aug 2023 09:08:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: dexter &lt;pmaier(a)sysmocom.de&gt; Gerrit-MessageType: comment