Attention is currently required from: keith, dexter.

Patch set 1:Code-Review -1

View Change

1 comment:

• File src/libosmo-mgcp/mgcp_conn.c:

  • Patch Set #1, Line 373: "rtp:%u<->%u rtcp:%u)",

    I don't know how long these lines are, but maybe print the port numbers directly behind ip, like "ip […]

    I think you probably want to clearly print remote and local IP+port together so it becomes way clearer.

    See for instance osmo_sockaddr_to_str() and osmo_sockaddr_to_str_buf().

    Maybe something like:

      snprintf(str, sizeof(str), "(%s/rtp, id:0x%s, local:%s (rtcp:%u), remote:%s 
                                   (rtcp:%u))", ...);
    				
    What does conn->name actually contain here btw?

To view, visit change 34150. To unsubscribe, or for help writing mail filters, visit settings.