[M] Change in osmo-sgsn[master]: sgsn_rim: forward message based on RIM ROUTING ADDRESS - gerrit-log

21 Aug 2023


      Attention is currently required from: dexter.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/34122 )
Change subject: sgsn_rim: forward message based on RIM ROUTING ADDRESS
......................................................................
Patch Set 3:
(1 comment)
File src/sgsn/sgsn_libgtp.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/34122/comment/66434cb1_a0b17378 
PS3, Line 721: 		rim_ra_discr = rim_ra_discr_encoded[0];
I really see no point in having these 2 vars here. Simply have a "uint8_t rim_ra_discr;" and pass it as "&rim_ra_discr" above in gtpie_gettlv.
This should simplify the code a bit at least.
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/34122
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Ifd2b915ed2f05130cff8ee77714b82005c17de3d
Gerrit-Change-Number: 34122
Gerrit-PatchSet: 3
Gerrit-Owner: dexter pmaier@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith osmith@sysmocom.de
Gerrit-CC: pespin pespin@sysmocom.de
Gerrit-Attention: dexter pmaier@sysmocom.de
Gerrit-Comment-Date: Mon, 21 Aug 2023 08:59:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment