Attention is currently required from: keith, dexter.

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/34150 )

Change subject: vty: include local port when dumping RTP conns ......................................................................

Patch Set 1: Code-Review-1

(1 comment)

File src/libosmo-mgcp/mgcp_conn.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/34150/comment/923d1c04_8bf53803 PS1, Line 373: "rtp:%u<->%u rtcp:%u)",

I don't know how long these lines are, but maybe print the port numbers directly behind ip, like "ip […]

I think you probably want to clearly print remote and local IP+port together so it becomes way clearer.

See for instance osmo_sockaddr_to_str() and osmo_sockaddr_to_str_buf().

Maybe something like:

snprintf(str, sizeof(str), "(%s/rtp, id:0x%s, local:%s (rtcp:%u), remote:%s (rtcp:%u))", ...); What does conn->name actually contain here btw?