Attention is currently required from: laforge, fixeria, dexter.

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31417 )

Change subject: l1sap: Accept RFC5993 and TS 101.318 HR GSM payload ......................................................................

Patch Set 1:

(1 comment)

File src/common/l1sap.c:

https://gerrit.osmocom.org/c/osmo-bts/+/31417/comment/db63200b_f2722efe PS1, Line 1261: resp_msg->len != GSM_HR_BYTES + 1

makes sense to use OSMO_UNLIKELY here

You can actually have 1 conditional block level less, all of it under UNLIKELY: if (OSMO_UNLIKELY(osmo_bts_has_feature(lchan->ts->trx->bts->features, BTS_FEAT_SPEECH_H_V1_RFC5993) && resp_msg->len != GSM_HR_BYTES + 1) { ... }

Then you can do early return on each case, and everything looks way simplier.