Attention is currently required from: laforge, fixeria, dexter.

View Change

1 comment:

• File src/common/l1sap.c:

  • Patch Set #1, Line 1261: resp_msg->len != GSM_HR_BYTES + 1

    makes sense to use OSMO_UNLIKELY here

    You can actually have 1 conditional block level less, all of it under UNLIKELY:
     if (OSMO_UNLIKELY(osmo_bts_has_feature(lchan->ts->trx->bts->features, BTS_FEAT_SPEECH_H_V1_RFC5993) && resp_msg->len != GSM_HR_BYTES + 1) {
     ...
     }
     
     Then you can do early return on each case, and everything looks way simplier.

To view, visit change 31417. To unsubscribe, or for help writing mail filters, visit settings.