Attention is currently required from: osmith, dexter.

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34192 )

Change subject: pcuif_proto: check confirm flag in struct gsm_pcu_if_pch ......................................................................

Patch Set 2: Code-Review-1

(5 comments)

Commit Message:

https://gerrit.osmocom.org/c/osmo-bsc/+/34192/comment/f4493e8c_4f1e0c93 PS2, Line 11: PCH, we have not the same flexibility as we have it in osmo-bsc. you mean osmo-bts here?

https://gerrit.osmocom.org/c/osmo-bsc/+/34192/comment/bbe0f1dc_390c8ddc PS2, Line 14: osmo-bts (cofirm PAGING messages, send non confirmed IMMEDIATE confirm

File src/osmo-bsc/pcu_sock.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/34192/comment/0fb28540_cd9a752b PS2, Line 559: if (!pch->confirm) why are you making so many suppositions here? Just do whatever the request asks you to do. The logic on what's needed is based in osmo-pcu, not here. Some versions of PCU may require confirmations, some not. Just stick to what the primitive asks.

https://gerrit.osmocom.org/c/osmo-bsc/+/34192/comment/245d3d6b_9a8a13ed PS2, Line 561: "PCU sends IMMEDIATE ASSIGNMENT via PCH but requests no conformation, will send confirmation anyway!\n"); confirmation

https://gerrit.osmocom.org/c/osmo-bsc/+/34192/comment/86d227db_a0174dd9 PS2, Line 566: if (pch->confirm) this also should go out.