Attention is currently required from: osmith, dexter.

Patch set 2:Code-Review -1

View Change

5 comments:

• Commit Message:

  • Patch Set #2, Line 11: PCH, we have not the same flexibility as we have it in osmo-bsc.

    you mean osmo-bts here?

  • Patch Set #2, Line 14: osmo-bts (cofirm PAGING messages, send non confirmed IMMEDIATE

    confirm

• File src/osmo-bsc/pcu_sock.c:

  • Patch Set #2, Line 559: if (!pch->confirm)

    why are you making so many suppositions here? Just do whatever the request asks you to do. The logic on what's needed is based in osmo-pcu, not here. Some versions of PCU may require confirmations, some not. Just stick to what the primitive asks.

  • Patch Set #2, Line 561: "PCU sends IMMEDIATE ASSIGNMENT via PCH but requests no conformation, will send confirmation anyway!\n");

    confirmation

  • Patch Set #2, Line 566: if (pch->confirm)

    this also should go out.

To view, visit change 34192. To unsubscribe, or for help writing mail filters, visit settings.