Attention is currently required from: dexter, fixeria, neels, pespin.

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/36363?usp=email )

Change subject: Convert RTP/RTCP/OSMUX I/O from osmo_fd to osmo_io ......................................................................

Patch Set 4:

(5 comments)

File src/libosmo-mgcp/mgcp_network.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/36363/comment/d7843810_68ce3add PS4, Line 1047: * \param[in] msg message buffer that holds the data to be send.

Please document here: […]

Done

https://gerrit.osmocom.org/c/osmo-mgw/+/36363/comment/b60c709c_b5cddd7c PS4, Line 1520: .from_addr = (struct osmo_sockaddr *) saddr,

I odn't see why the cast is needed here? saddr is already that type.

but not const... we need to de-constify it, as 'struct osmo_rtp_msg_ctx' has a non-const from_addr member.

https://gerrit.osmocom.org/c/osmo-mgw/+/36363/comment/0568d840_72e84b46 PS4, Line 1696: if ((end->rtp && osmo_iofd_get_fd(end->rtp) != -1) ||

You can probably skip the "osmo_iofd_get_fd(end->rtp) != -1" check here, or otherwise make sure you […]

I originally did not have that check in place and it created problems (I think a crash). I don't recall the details. In any case, I'm just translating the old code with its -1 check to osmo_io. Anything else would be outside of the scope of this patch. The smaller such a patch is, and the less it changes the existing code, the better.

File src/libosmo-mgcp/mgcp_osmux.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/36363/comment/e178a3da_f902f6c6 PS4, Line 526: goto out_free_v4;

you may be missing an "osmo_iofd_unregister()" in the section you are going with goto here. […]

osmo_iofd_free() includes both closing and unregistering. This is documented in the omsmo_iofd documentation, and the code even has a comment below at the goto label that explicitly explains/states this.

File tests/mgcp/mgcp_test.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/36363/comment/385b76a2_6a1da5ee PS4, Line 661: uint8_t *buf = msgb_data(msg);

const

Done