Attention is currently required from: dexter, fixeria, neels, pespin.

View Change

5 comments:

• File src/libosmo-mgcp/mgcp_network.c:

  • Patch Set #4, Line 1047: * \param[in] msg message buffer that holds the data to be send.

    Please document here: […]

    Done

  • Patch Set #4, Line 1520: .from_addr = (struct osmo_sockaddr *) saddr,

    I odn't see why the cast is needed here? saddr is already that type.

    but not const... we need to de-constify it, as 'struct osmo_rtp_msg_ctx' has a non-const from_addr member.

  • Patch Set #4, Line 1696: if ((end->rtp && osmo_iofd_get_fd(end->rtp) != -1) ||

    You can probably skip the "osmo_iofd_get_fd(end->rtp) != -1" check here, or otherwise make sure you […]

    I originally did not have that check in place and it created problems (I think a crash). I don't recall the details. In any case, I'm just translating the old code with its -1 check to osmo_io. Anything else would be outside of the scope of this patch. The smaller such a patch is, and the less it changes the existing code, the better.

• File src/libosmo-mgcp/mgcp_osmux.c:

  • Patch Set #4, Line 526: goto out_free_v4;

    you may be missing an "osmo_iofd_unregister()" in the section you are going with goto here. […]

    osmo_iofd_free() includes both closing and unregistering. This is documented in the omsmo_iofd documentation, and the code even has a comment below at the goto label that explicitly explains/states this.

• File tests/mgcp/mgcp_test.c:

  • Patch Set #4, Line 661: uint8_t *buf = msgb_data(msg);

    const

    Done

To view, visit change 36363. To unsubscribe, or for help writing mail filters, visit settings.