Attention is currently required from: fixeria, laforge, pespin.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/36115?usp=email )
Change subject: ipa: Use pseudo-random number for SLS in IPA->M3UA direction
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
File src/osmo_ss7_asp.c:
https://gerrit.osmocom.org/c/libosmo-sccp/+/36115/comment/69a48213_9391421c
PS2, Line 990: asp->asp_id = rand() & 0xf;
yes. I didn't want to break ABI.
How I understand this, asp->asp_id is not used in the IPA code paths (but in the SCTP/M3UA code paths it is used). This means the field is free to be used for the random number.
Maybe it makes sense to put a short comment about this.
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-sccp/+/36115?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: Ia4e66d660b6057338f66a47fffc8a0d32759f733
Gerrit-Change-Number: 36115
Gerrit-PatchSet: 3
Gerrit-Owner: laforge
laforge@osmocom.org
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter
pmaier@sysmocom.de
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Wed, 06 Mar 2024 16:49:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge
laforge@osmocom.org
Comment-In-Reply-To: pespin
pespin@sysmocom.de
Gerrit-MessageType: comment