Attention is currently required from: fixeria, laforge, pespin.
Patch set 3:Code-Review +1
View Change
1 comment:
File src/osmo_ss7_asp.c:
Patch Set #2, Line 990: asp->asp_id = rand() & 0xf;
yes. I didn't want to break ABI.
How I understand this, asp->asp_id is not used in the IPA code paths (but in the SCTP/M3UA code paths it is used). This means the field is free to be used for the random number.
Maybe it makes sense to put a short comment about this.
To view, visit change 36115. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: Ia4e66d660b6057338f66a47fffc8a0d32759f733
Gerrit-Change-Number: 36115
Gerrit-PatchSet: 3
Gerrit-Owner: laforge <laforge@osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier@sysmocom.de>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Comment-Date: Wed, 06 Mar 2024 16:49:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge <laforge@osmocom.org>
Comment-In-Reply-To: pespin <pespin@sysmocom.de>
Gerrit-MessageType: comment