Attention is currently required from: neels.

laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/40096?usp=email )

Change subject: personalization: add param_source.py, implement batch personalization ......................................................................

Patch Set 10:

(3 comments)

File pySim/esim/saip/param_source.py:

https://gerrit.osmocom.org/c/pysim/+/40096/comment/b72f1045_0a1b2da0?usp=ema... : PS10, Line 50: This is dead code. You would just write `pass` here as it is impossible to instantiate an instance of an ABC-inheriting class without overriding all the abstractmethods in that derived class.

https://gerrit.osmocom.org/c/pysim/+/40096/comment/e47f088e_2679bd4c?usp=ema... : PS10, Line 84: likewise here, just `pass` will do.

File pySim/esim/saip/personalization.py:

https://gerrit.osmocom.org/c/pysim/+/40096/comment/9c3482f5_4e1f1342?usp=ema... : PS10, Line 705: def __init__(self, highly unusual formatting which we don't do this way in any other part o the code. Do we really need those kind of cosmetic experiments? Also, we use spaces between name of the parameter and the type annotation. I'm not sure why code added doesn't just by default always uses the surrounding style without any attempt to do something different.