Attention is currently required from: neels.
3 comments:
File pySim/esim/saip/param_source.py:
This is dead code. You would just write `pass` here as it is impossible to instantiate an instance of an ABC-inheriting class without overriding all the abstractmethods in that derived class.
likewise here, just `pass` will do.
File pySim/esim/saip/personalization.py:
Patch Set #10, Line 705: def __init__(self,
highly unusual formatting which we don't do this way in any other part o the code. Do we really need those kind of cosmetic experiments? Also, we use spaces between name of the parameter and the type annotation. I'm not sure why code added doesn't just by default always uses the surrounding style without any attempt to do something different.
To view, visit change 40096. To unsubscribe, or for help writing mail filters, visit settings.