Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/29402 )

Change subject: llc: implement LLC PDU codec based on code from osmo-sgsn.git ......................................................................

Patch Set 2:

(3 comments)

Patchset:

PS2: Please fix the linter warnings which make sense.

File include/osmocom/gprs/llc/llc.h:

https://gerrit.osmocom.org/c/libosmo-gprs/+/29402/comment/cd9e8861_b42caff3 PS2, Line 135: #define OSMO_GPRS_LLC_PDU_F_ACK_REQ (1 << 2) /* 6.3.5.2 Acknowledgement request bit (A) */

'Acknowledgement' may be misspelled - perhaps 'Acknowledgment'?

Please fix.

File src/llc/llc_pdu.c:

https://gerrit.osmocom.org/c/libosmo-gprs/+/29402/comment/85f2e38d_4f21290a PS2, Line 157: ctrl[0] |= (pdu->seq_tx >> 4) & 0x1f; looks like we want a packed struct for "ctrl" here?