Attention is currently required from: fixeria.

View Change

3 comments:

• Patchset:

  • Patch Set #2:

    Please fix the linter warnings which make sense.

• File include/osmocom/gprs/llc/llc.h:

  • Patch Set #2, Line 135: #define OSMO_GPRS_LLC_PDU_F_ACK_REQ (1 << 2) /* 6.3.5.2 Acknowledgement request bit (A) */

    'Acknowledgement' may be misspelled - perhaps 'Acknowledgment'?

    Please fix.

• File src/llc/llc_pdu.c:

  • Patch Set #2, Line 157: ctrl[0] |= (pdu->seq_tx >> 4) & 0x1f;

    looks like we want a packed struct for "ctrl" here?

To view, visit change 29402. To unsubscribe, or for help writing mail filters, visit settings.